Simplify new_kernel_name implementation in tests

[SergeyKopienko]

In this PR we simplify new_kernel_name implementation in tests.
The goal - to make generated new Kernel names more short and simple.

Example

Let's take a look to the code (for example):

auto new_policy = make_new_policy<new_kernel_name<Policy, 0>>(exec);

• before this PR, the type of new_policy is

oneapi::dpl::execution::__dpl::device_policy<TestUtils::unique_kernel_name<oneapi::dpl::execution::__dpl::device_policy<TestUtils::unique_kernel_name<test_binary_search<unsigned long long>,0>>,0>>

• after this PR, the type of new_policy is

oneapi::dpl::execution::__dpl::device_policy<TestUtils::unique_kernel_name<TestUtils::unique_kernel_name<test_binary_search<unsigned long long>,0>,0>>

[danhoeflinger]

Can we take this opportunity to consolidate this to a single instance of this implementation?

[danhoeflinger]

Is there a reason there are 2 nested copies of TestUtils::unique_kernel_name here?
Are they redundant? If we change the number from 0 to 1, in your code, do both copies of the TestUtils::unique_kernel_name change their number? If so, there is some other issue we can fix I think.

[SergeyKopienko]

Is there a reason there are 2 nested copies of TestUtils::unique_kernel_name here? Are they redundant? If we change the number from 0 to 1, in your code, do both copies of the TestUtils::unique_kernel_name change their number? If so, there is some other issue we can fix I think.

In any case now new_kernel_name is implemented in this PR exactly as

template <typename Policy>
using __policy_kernel_name = typename ::std::decay_t<Policy>::kernel_name;

[danhoeflinger]

In any case now new_kernel_name is implemented in this PR exactly as

template <typename Policy>
using __policy_kernel_name = typename ::std::decay_t<Policy>::kernel_name;

Yes, but in your "after" result, we still have 2 nested TestUtils::unique_kernel_name. Perhaps that is because of nesting in the test function you are using to generate the "before" and "after", and is required and intentional.

[SergeyKopienko]

In any case now new_kernel_name is implemented in this PR exactly as

template <typename Policy>
using __policy_kernel_name = typename ::std::decay_t<Policy>::kernel_name;

Yes, but in your "after" result, we still have 2 nested TestUtils::unique_kernel_name. Perhaps that is because of nesting in the test function you are using to generate the "before" and "after", and is required and intentional.

As example I have used the policy creation at

oneDPL/test/parallel_api/algorithm/alg.sorting/alg.binary.search/binary.search/binary_search.pass.cpp

Line 74 in f5bd154

auto new_policy = make_new_policy<new_kernel_name<Policy, 0>>(exec);

:

auto new_policy = make_new_policy<new_kernel_name<Policy, 0>>(exec);

at this point the type of exec is oneapi::dpl::execution::__dpl::device_policy<TestUtils::unique_kernel_name<test_binary_search<unsigned long long>,0>> &
and the type of new_policy is
oneapi::dpl::execution::__dpl::device_policy<TestUtils::unique_kernel_name<TestUtils::unique_kernel_name<test_binary_search<unsigned long long>,0>,0>>

So I think it's the question for test environment staff, not for new_kernel_name :

• this type name starts from

template <::std::size_t CallNumber = 0>
struct invoke_on_all_hetero_policies::operator()(Op op, Args&&... rest)

[Copilot]

Pull Request Overview

This PR centralizes and simplifies the new_kernel_name machinery for tests by moving common templates into a single header and removing redundant definitions elsewhere.

• Introduce uniq_kernel_index, unique_kernel_name, and new_kernel_name in utils_sycl_defs.h
• Remove duplicated template definitions from utils_invoke.h, test_dynamic_selection_utils.h, and test_dynamic_load_utils.h
• Include utils_sycl_defs.h where those utilities were previously declared inline

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
test/support/utils_sycl_defs.h	Added uniq_kernel_index, forward-declared unique_kernel_name, and new_kernel_name alias
test/support/utils_invoke.h	Removed inline duplicates and included utils_sycl_defs.h
test/support/test_dynamic_selection_utils.h	Removed inline duplicates and included utils_sycl_defs.h
test/support/test_dynamic_load_utils.h	Removed inline duplicates and included utils_sycl_defs.h

Comments suppressed due to low confidence (3)

test/support/utils_sycl_defs.h:44

• [nitpick] Consider renaming uniq_kernel_index to unique_kernel_index for consistency with unique_kernel_name and to improve readability.

uniq_kernel_index()

test/support/utils_sycl_defs.h:49

• [nitpick] Add a brief comment above this forward declaration to explain the purpose of unique_kernel_name and how it is used in the test framework.

template <typename Op, std::size_t CallNumber>

test/support/utils_sycl_defs.h:42

• Consider adding unit tests for uniq_kernel_index to verify that it returns the correct numeric values for each sycl::usm::alloc enumerator.

template <sycl::usm::alloc alloc_type>