Integrating Relative Error Handling in convex_hull, count_string and parallel_preorder #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnmokhov
reviewed
Mar 10, 2025
Comment on lines
+41
to
+43
| static constexpr std::size_t hash_multiplier = | ||
| (std::size_t)((sizeof(std::size_t) == sizeof(unsigned)) ? 2654435769U | ||
| : 11400714819323198485ULL); |
Comment on lines
137
to
+138
| Index end; | ||
| edge(Index _p1, Index _p2) : start(_p1), end(_p2){}; | ||
| edge(Index _p1, Index _p2) : start(_p1), end(_p2) {}; |
Comment on lines
276
to
278
| if (!util::silent) { | ||
| std::cout << "Starting TBB-buffered version of QUICK HULL algorithm" | ||
| << "\n"; | ||
| std::cout << "Starting TBB-buffered version of QUICK HULL algorithm" << "\n"; | ||
| } |
dnmokhov
reviewed
Mar 10, 2025
Comment on lines
+69
to
+70
| if (numberOfIterations <= 0) { | ||
| std::cout << "Setting the number of iterations = " << numberOfIterations << " default\n"; |
There was a problem hiding this comment.
The user-specified non-positive value is used here instead of the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrated utility class measurement for relative error analysis in mentioned examples.
Default values of n-of-iterations set to best scenarios found in initial analysis.
Fixes # - #1653
Co-authored-by: Hussain, Shaik (shaik.hussain@intel.com)
Signed-off-by: Hussain, Shaik (shaik.hussain@intel.com)
Signed-off-by: Verma, Rahul (rahul3.verma@intel.com)
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@shaikhus12122864to send notificationsOther information