-
Notifications
You must be signed in to change notification settings - Fork 1.1k
POC implementation for task_group dynamic dependencies - part 2 - make_edge #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kboyarinov
wants to merge
16
commits into
dev/kboyarinov/poc-dynamic-dependencies-part1
Choose a base branch
from
dev/kboyarinov/poc-dynamic-dependencies-part2
base: dev/kboyarinov/poc-dynamic-dependencies-part1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
POC implementation for task_group dynamic dependencies - part 2 - make_edge #1685
kboyarinov
wants to merge
16
commits into
dev/kboyarinov/poc-dynamic-dependencies-part1
from
dev/kboyarinov/poc-dynamic-dependencies-part2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/kboyarinov/poc-dynamic-dependencies-part2
…/kboyarinov/poc-dynamic-dependencies-part2
13 tasks
…dencies-part1' into dev/kboyarinov/poc-dynamic-dependencies-part2
kboyarinov
commented
May 20, 2025
13 tasks
…dencies-part1' into dev/kboyarinov/poc-dynamic-dependencies-part2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second part of POC implementation for task_group dynamic dependencies.
Design described in the RFC #1664
First part is implemented in the PR #1682
This PR extends the
task_group
API with the new methodmake_edge
that allows to specify predecessor-successor dependency between two tasks.task_dynamic_state
class was extended to contain current continuation vertex and the successors list.Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information