Fix/suppress new GCC warnings #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this, @gzz2000. Could you please update the copyright year in the modified file: https://github.com/uxlfoundation/oneTBB/actions/runs/15627205507/job/44023614533 |
Sure, updated. |
kboyarinov
reviewed
Jun 15, 2025
| @@ -437,7 +437,16 @@ class concurrent_monitor_base { | |||
| my_waitset.flush_to(temp); | |||
| end = temp.end(); | |||
| for (base_node* n = temp.front(); n != end; n = n->next) { | |||
| // GCC 12.x-14.x issues a warning here that to_wait_node(n)->my_is_in_list might have size 0, since n is | |||
| // a base_node pointer. (This cannot happen, because only wait_node pointers are added to my_waitset.) | |||
| #if (__TBB_GCC_VERSION >= 120100 && __TBB_GCC_VERSION < 150000 ) && !__clang__ && !__INTEL_COMPILER | |||
There was a problem hiding this comment.
Since the same warning is suppressed on the line 296 and the macros in the "#if" statement are the same, we have the same if statement 4 times. I propose to define the special macro with the content of the statement and reuse it in these 4 places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1192 the warning Wstringop-overflow was ignored for some GCC versions. I applied the same pragma to another new spot (
concurrent_monitor.h:440) where the warning is also being false-positively triggered now.Fixes #1508
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information