[CITY_RUNNER] Add the concept of known test for city runner lit #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look in more detail later today, but one thing that jumps out is that unknown passes/fails are reported after known passes/fails. Failures in known tests that we expect to pass are of most interest to us and I think those should be at the end so we can easily see them. |
hvdijk
reviewed
Jun 18, 2025
hvdijk
reviewed
Jun 18, 2025
coldav
force-pushed
the
colin/extend_city_runner_unknown
branch
2 times, most recently
from
56156d0 to
4e50547
Compare
if the lit profile is passed a csv file it treats all the entries in there as known and also updates the attributes based on it. Any unknown ones will not trigger an overall failure but will be reported.
coldav
force-pushed
the
colin/extend_city_runner_unknown
branch
from
4e50547 to
df12e27
Compare
hvdijk
reviewed
Jun 19, 2025
hvdijk
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the concept of known test for city runner lit
Reason for change
e2e testing was too variable, and adding too much overhead
Description of change
If the lit profile is passed a csv file it treats all the entries in there as known and also updates the attributes based on it. Any unknown ones will not trigger an overall failure but will be reported.