-
Notifications
You must be signed in to change notification settings - Fork 182
Add grain_size hyperparameter into EmpiricalCovariance and PCA algorithms #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/intelci: run |
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks relatively ready to go, code is easy to read and follows convention. Rather than using lambdas, you can reference the hyperparameter type's methods directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran the timed-out windows CI job, and make sure to finish the checklist. I think with a private CI run and @david-cortes-intel 's point addressed we can approve this.
"-style=file:" + formatfile, | ||
] | ||
) | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. Its one of those hidden things for development that catches me from time to time. Nitpick would be to add a note in the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also have problems with it from time to time. Decided to put an end to those :)
I've updated the description.
/intelci: run |
cpu_grain_size
hyperparameter was added toEmpiricalCovariance
estimator.cpu_grain_size
andcpu_macro_block
hyperparameters were added toPCA
estimator.gen_daal4py.py
was modified to report the problem withclang-format
installation on the setup stage.PR completeness and readability
Testing
Performance
not applicable