FIX: Fix table destructor not being called #2540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
icfaust
reviewed
Jun 13, 2025
There was a problem hiding this comment.
I'm going to adapt this PR into #2364 and see if it helps some of the memory leak fails. Because this affects return values regardless of the inputs, I think it might also address this sporadic k-Means failure. Just a small change but otherwise I expect its basically good to go.
Co-authored-by: Ian Faust <icfaust@gmail.com>
This was referenced Jun 13, 2025
|
/intelci: run |
david-cortes-intel
requested review from
Alexsandruss,
ethanglaser and
Vika-F
as code owners
|
/intelci: run |
Vika-F
approved these changes
Jun 16, 2025
|
/intelci: run |
1 similar comment
|
/intelci: run |
|
@david-cortes-intel please merge in main and re-run private CI |
david-cortes-intel
requested review from
yuejiaointel,
ahuber21,
napetrov,
homksei,
maria-Petrova and
syakov-intel
as code owners
david-cortes-intel
force-pushed
the
fix_uncalled_destructor
branch
from
f4d73ae to
51ac59c
Compare
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #1869
This PR fixes an issue with the destructor for table objects not being called when the python objects are deallocated.
The fix needs to be tested more thoroughly through sanitizers and valgrind when possible.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing