refactoring: refactor the server side tool definitions #6827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancer
changed the title
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
| @@ -21,7 +21,7 @@ export async function POST(req: Request) { | |||
| const result = streamText({ | |||
| model: anthropic('claude-3-5-sonnet-latest'), | |||
| tools: { | |||
| web_search: anthropic.tools.webSearch_20250305(), | |||
| web_search: anthropic.tools.webSearch_20250305({}), | |||
There was a problem hiding this comment.
wonder if we can provide a default? might be tricky
lgrammel
reviewed
Jun 23, 2025
| @@ -7,7 +7,7 @@ async function main() { | |||
| model: openai.responses('gpt-4o-mini'), | |||
| prompt: 'What happened in San Francisco last week?', | |||
| tools: { | |||
| web_search_preview: openai.tools.webSearchPreview(), | |||
| web_search_preview: openai.tools.webSearchPreview({}), | |||
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
|
needs a changeset since it updates the api for tool use slightly |
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
lgrammel
reviewed
Jun 23, 2025
lgrammel
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
refactor server-side tool definition - some used function-based exports while others used the
createProviderDefinedToolFactorypattern established bycomputer_20250124.ts.summary
createProviderDefinedToolFactorypatternverification
tasks
packages/openai/src/tool/web-search-preview.tsto factory patternpackages/openai/src/tool/file-search.tsto factory patternpackages/anthropic/src/tool/web-search_20250305.tsto factory patternfuture work