Improve Form Error Accessibility #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tan-Aki
reviewed
Nov 16, 2023
|
Great job, and swift! Btw, this problem is also present on the app/ui/login-form.tsx in chapter 15
Cheers! |
|
Thank you for taking the time @Tan-Aki! 🖤 |
|
Great job! Cheers. |
leerob
approved these changes
Nov 16, 2023
|
The documentation for this part, says "Add a ternary operator that checks for each specific error. For example, after the customer's field, you can add:" Whilst the updated code does not use a ternary op anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aria-liveregion for form errors needs to be present in the DOM to allow screen readers to monitor changes. This PR updates the structure, and moves the label outside the conditional.More context: #418
See also: https://dev.to/abbeyperini/live-regions-in-react-4dmd
PR to update the chapter: https://github.com/vercel/front/pull/27101