Skip to content

[frameworks] Add Nitro as framework #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2025
Merged

Conversation

onsclom
Copy link
Contributor

@onsclom onsclom commented Jun 20, 2025

nitro build detects the env var VERCEL=1 and emits build output API code, so Nitro already works great on Vercel with zero configuration.

Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: c2f966d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/frameworks Minor
@vercel/fs-detectors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

onsclom added a commit to vercel/examples that referenced this pull request Jun 20, 2025
### Description

Nitro build detects the env var `VERCEL=1` and emits build output API
code, so Nitro already works great on Vercel with zero configuration.
This example is necessary to add the [Nitro framework
entry](vercel/vercel#13472).

### Demo URL

https://nitro-template.vercel.app

### Type of Change

- [X] New Example
- [ ] Example updates (Bug fixes, new features, etc.)
- [ ] Other (changes to the codebase, but not to examples)

### New Example Checklist

- [ ] 🛫 `npm run new-example` was used to create the example
- [X] 📚 The template wasn't used but I carefuly read the [Adding a new
example](https://github.com/vercel/examples#adding-a-new-example) steps
and implemented them in the example
- [X] 📱 Is it responsive? Are mobile and tablets considered?
@onsclom onsclom marked this pull request as ready for review June 20, 2025 19:27
@onsclom onsclom requested a review from a team as a code owner June 20, 2025 19:27
@onsclom onsclom requested review from balazs4 and kitfoster June 20, 2025 19:27
@@ -1529,6 +1529,7 @@ export const frameworks = [
website: 'https://nuxtjs.org',
sort: 2,
envPrefix: 'NUXT_ENV_',
supersedes: ['nitro'],
Copy link
Contributor Author

@onsclom onsclom Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Nuxt projects sometimes list nitro as dep, and we want to prefer Nuxt for detection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is the right call - nitro is likely to be used by other frameworks as well so should generally be lower priority.

tknickman
tknickman previously approved these changes Jun 20, 2025
Copy link

socket-security bot commented Jun 20, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​nitropack@​2.11.12961008789100

View full report

@@ -0,0 +1,5 @@
import { deployExample } from '../test-utils';
// eslint-disable-next-line jest/no-disabled-tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error on with this test that goes away with a redeploy. Skipping for now because it works when manually deploying.

https://vercel.com/zero-conf-vtest314/nitro/FsHW5Q856PEFQ7cwVSb8HZa4dTNP?filter=errors#L40

@onsclom onsclom requested a review from tknickman June 20, 2025 20:51
@onsclom onsclom added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 419e234 Jun 20, 2025
151 checks passed
@onsclom onsclom deleted the austinmerrick/add-nitro-as-framework branch June 20, 2025 20:56
github-merge-queue bot pushed a commit that referenced this pull request Jun 23, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/frameworks@3.7.0

### Minor Changes

- Add Nitro to framework list
([#13472](#13472))

## @vercel/client@15.3.6

### Patch Changes

- Updated dependencies
\[[`8f791807ae04479e538c11ccd709b39ed210e477`](8f79180)]:
    -   @vercel/routing-utils@5.0.8

## @vercel/fs-detectors@5.4.5

### Patch Changes

- Updated dependencies
\[[`8f791807ae04479e538c11ccd709b39ed210e477`](8f79180),
[`419e2344e6d0883ddbec6cdd3adf2c2935a4951c`](419e234)]:
    -   @vercel/routing-utils@5.0.8
    -   @vercel/frameworks@3.7.0

## @vercel/routing-utils@5.0.8

### Patch Changes

- support transform rules in vercel.json
([#13464](#13464))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship added a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/frameworks@3.7.0

### Minor Changes

- Add Nitro to framework list
([#13472](vercel/vercel#13472))

## @vercel/client@15.3.6

### Patch Changes

- Updated dependencies
\[[`c76a462218db2b26dafb1893c3b8886b5fbc6c59`](vercel/vercel@c76a462)]:
    -   @vercel/routing-utils@5.0.8

## @vercel/fs-detectors@5.4.5

### Patch Changes

- Updated dependencies
\[[`c76a462218db2b26dafb1893c3b8886b5fbc6c59`](vercel/vercel@c76a462),
[`9afc0a23bd19f3d772feff9e60f240d6aa7c60b0`](vercel/vercel@9afc0a2)]:
    -   @vercel/routing-utils@5.0.8
    -   @vercel/frameworks@3.7.0

## @vercel/routing-utils@5.0.8

### Patch Changes

- support transform rules in vercel.json
([#13464](vercel/vercel#13464))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants