Update Wasp Studio (deps, Express, tsx) #2848
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
commented
Jun 18, 2025
| @@ -2,7 +2,6 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | |||
There was a problem hiding this comment.
vite.svg didn't exist, so this just ended up being a 404 in the network tab
infomiho
commented
Jun 18, 2025
| @@ -8,28 +8,25 @@ | |||
| "main": "index.js", | |||
| "keywords": [], | |||
| "scripts": { | |||
| "build": "npm run build:client && rm -rf dist && tsc && cp -r ./public ./dist/public", | |||
| "build": "npm run build:client && rm -rf ./client/node_modules && rm -rf dist && tsc && cp -r ./public ./dist/public", | |||
infomiho
commented
Jun 18, 2025
| "@fastify/cors": "^8.3.0", | ||
| "@fastify/static": "^6.11.2", | ||
| "commander": "^11.0.0", | ||
| "dotenv": "^16.0.3", |
There was a problem hiding this comment.
We didn't use .env files so I've removed dotenv as dep.
infomiho
commented
Jun 18, 2025
| root: new URL("./public", import.meta.url).pathname, | ||
| }); | ||
|
|
||
| app.use(morgan("dev")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade Wasp Studio:
ts-nodewithtsx(dev mode was broken, so I went withtsxwhich has a watch mode so I can removenodemon)nodemonsince it's no longer nededstudio/client/node_modulesto keep the binary size downAs a side-effect, all this fixed the issues with Wasp Studio not working in Firefox.
Closes #2774