Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum version to iOS 9 #1456

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jmagman
Copy link

@jmagman jmagman commented Mar 8, 2025

permission_handler_apple supports Flutter > 2.8.0, which had a minimum iOS requirement of iOS 9.

Increase the podspec version to iOS 9. Remove the iOS 8 and 9 availability checks.

Fixes #1455

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@jmagman jmagman marked this pull request as ready for review March 8, 2025 00:52
@@ -86,12 +86,6 @@ + (void)openAppSettings:(FlutterResult)result {
completionHandler:^(BOOL success) {
result([[NSNumber alloc] initWithBool:success]);
}];
} else if (@available(iOS 8.0, *)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, well this change would break between iOS 9 and 10.

@jmagman jmagman marked this pull request as draft March 17, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement proposal]: Update iOS minimum version to 9.0 or higher, delete dead fallback code
1 participant