Language server installation menu #1997
Open
+2,795
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastestMolasses
added
enhancement
CodeEdit/Features/LSP/Registry/PackageManagers/CargoPackageManager.swift
Show resolved
Hide resolved
|
Will need to fix lint errors, but besides that it is ready for review. |
FastestMolasses
requested review from
austincondiff,
matthijseikelenboom,
thecoolwinter and
tom-ludwig
|
Fix those SwiftLint errors plz 😬 |
tom-ludwig
requested changes
Mar 21, 2025
| } | ||
|
|
||
| let packagePath = installationDirectory.appending(path: source.entryName) | ||
| print("Installing \(source.entryName)@\(source.version) in \(packagePath.path)") |
There was a problem hiding this comment.
Suggested change
| print("Installing \(source.entryName)@\(source.version) in \(packagePath.path)") |
| } | ||
| return output.starts(with: "cargo") | ||
| } catch { | ||
| print("Cargo version check failed: \(error)") |
There was a problem hiding this comment.
Suggested change
| print("Cargo version check failed: \(error)") |
| let repoPath = installPath.appending(path: source.pkgName, directoryHint: .isDirectory) | ||
| _ = try await executeInDirectory(in: repoPath.path, [command]) | ||
| } catch { | ||
| print("Failed to build from source: \(error)") |
There was a problem hiding this comment.
Suggested change
| print("Failed to build from source: \(error)") |
| if !FileManager.default.fileExists(atPath: packagePath.path) { | ||
| throw RegistryManagerError.downloadFailed( | ||
| url: url, | ||
| error: NSError(domain: "Coould not download package", code: -1) |
There was a problem hiding this comment.
Suggested change
| error: NSError(domain: "Coould not download package", code: -1) | |
| error: NSError(domain: "Could not download package", code: -1) |
| } | ||
|
|
||
| let packagePath = installationDirectory.appending(path: source.entryName) | ||
| print("Installing Go package \(source.entryName)@\(source.version) in \(packagePath.path)") |
There was a problem hiding this comment.
Suggested change
| print("Installing Go package \(source.entryName)@\(source.version) in \(packagePath.path)") |
|
|
||
| print("Successfully installed \(source.entryName)@\(source.version)") | ||
| } catch { | ||
| print("Installation failed: \(error)") |
There was a problem hiding this comment.
Suggested change
| print("Installation failed: \(error)") |
| } | ||
|
|
||
| let packagePath = installationDirectory.appending(path: source.entryName) | ||
| print("Installing \(source.entryName)@\(source.version) in \(packagePath.path)") |
There was a problem hiding this comment.
Suggested change
| print("Installing \(source.entryName)@\(source.version) in \(packagePath.path)") |
| } | ||
|
|
||
| let extras = source.options["extra"] | ||
| if let extras = extras { |
There was a problem hiding this comment.
Suggested change
| if let extras = extras { | |
| if let extras { |
Comment on lines
+70
to
+71
|
|
||
| print("Successfully installed \(source.entryName)@\(source.version)") |
There was a problem hiding this comment.
Suggested change
| print("Successfully installed \(source.entryName)@\(source.version)") |
|
|
||
| print("Successfully installed \(source.entryName)@\(source.version)") | ||
| } catch { | ||
| print("Installation failed: \(error)") |
There was a problem hiding this comment.
Suggested change
| print("Installation failed: \(error)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A system to allow users to download and manage LSP servers from the settings menu. This utilizes the mason registry to track the language servers.
Related Issues
Checklist
Screenshots