Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the golangci-lint "import" preset #4139

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Mar 19, 2025

Most of our files are close to this convention already. The errors reported by "gci" have improved enough to be useful and it can fix typos automatically.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Other

cbandy added 2 commits March 19, 2025 14:29
Most of our files are close to this convention already. The errors
reported by "gci" have improved enough to be useful and it can fix
typos automatically.
The "performance" preset of golangci-lint detected this. Add that preset
to the linter report in GitHub workflows.
@cbandy cbandy merged commit db1c90d into CrunchyData:main Mar 20, 2025
19 checks passed
@cbandy cbandy deleted the lint-imports branch March 20, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants