Remove yellowBox observer on dealloc (wix#7015)

yogevbd · Yogev Ben David · yogevbd · commit 8dbcb2d0b9ba · 2021-03-09T08:57:27.000+02:00
This PR fixes a crash caused by a KVO observer that isn't cleared. Closes wix#7009 Co-authored-by: Yogev Ben David <yogevbd@wixs-MacBook-Pro.local>
diff --git a/lib/ios/RNNComponentView.m b/lib/ios/RNNComponentView.m
@@ -44,6 +44,14 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
         }
     }
 }
+
+- (void)dealloc {
+    if (_observeLayerChange) {
+        [self.subviews.firstObject.subviews.firstObject.layer removeObserver:self
+                                                                  forKeyPath:@"sublayers"];
+    }
+}
+
 #endif
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,14 @@ - (void)observeValueForKeyPath:(NSString *)keyPath`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`	`}`
	`47`	`+`
	`48`	`+- (void)dealloc {`
	`49`	`+ if (_observeLayerChange) {`
	`50`	`+ [self.subviews.firstObject.subviews.firstObject.layer removeObserver:self`
	`51`	`+ forKeyPath:@"sublayers"];`
	`52`	`+ }`
	`53`	`+}`
	`54`	`+`
`47`	`55`	`#endif`
`48`	`56`
`49`	`57`	`@end`