Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a common sourceSet in between wasmJs and JS targets to publish … #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JSMonk
Copy link
Member

@JSMonk JSMonk commented Mar 10, 2025

…both variants from the single source

@JSMonk JSMonk requested a review from igoriakovlev March 10, 2025 10:35
@JSMonk
Copy link
Member Author

JSMonk commented Mar 10, 2025

Don't merge it until the kotlin-wasm-js-interop library is published

@JSMonk JSMonk force-pushed the introduce-js-variant-of-kotlinx-browser branch from d2d4432 to a39765a Compare March 11, 2025 09:36
@@ -26,6 +28,7 @@ afterEvaluate {

repositories {
mavenCentral()
mavenLocal()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to commit mavenLocal here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so.

@ygdrasil-io
Copy link

Don't merge it until the kotlin-wasm-js-interop library is published

any ETA ?

@JSMonk
Copy link
Member Author

JSMonk commented Mar 17, 2025

Don't merge it until the kotlin-wasm-js-interop library is published

any ETA ?

We're looking forward to introducing support for it as soon as possible. However, we want to make the transition to this library less painful and backward compatible with the declarations in our stdlib. So, I hope we will have a final shape of changes in this library and the compiler in April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants