Changed the default value for max_open_connections to one.

[christ0pher]

If the value is Leq 0 an error over the python logging system ist emitted. This can be used to catch failures over network logging and custom defined handlers.

Connections are now checked only against the max_open property.

[methane]

Why should I change the default?
Why not use exception instead of logging?

[christ0pher]

Hi,

1. The default value should be a reasonable value. 0 for unlimited open connections looks more like a hack to me, instead of a reasonable value. Unlimited connections do not make sense in the context of databases (e.g file descriptor limit). If you use a pool a reasonable value is 1 to open at max one connection.
2. exceptions in constructors are not a nice way to show the error. Better way is to set the default value to a reasonable value. Also an unlimited amout of connections will crash the db if the load gets too high.

best

[methane]

The default value should be a reasonable value. 0 for unlimited open connections looks more like a hack to me, instead of a reasonable value. Unlimited connections do not make sense in the context of databases (e.g file descriptor limit). If you use a pool a reasonable value is 1 to open at max one connection.

I don't feel 1 is reasonable value. It's too small for real application.

http://golang.org/pkg/database/sql/#DB.SetMaxOpenConns
Go's connection pool is unlimited by default.

exceptions in constructors are not a nice way to show the error.

I disagree. Exception is better than logging.
Python's Zen saids:

Errors should never pass silently.

I really like it. If people misconfigured, libraries should crash ASAP.

[christ0pher]

Ok. i will change it to an exception.

But still initializing databasepools with unlimited connections is not the way to go. Even in GO.

[christ0pher]

Additional thoughts to the commit message:
If you have a product and many services can open unlimited connection pools to the database, it is possible to bring down your hole product with just one service.
People who program should be aware what they are doing, but sometimes a little hint might be useful to build more reliable systems.

[methane]

remove this

[methane]

Our company use this module in production already.
Please don't break backward compatibility so easy.