Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: Decrement ._opened_conns when connect() raises exception #9

Merged
merged 2 commits into from
Mar 13, 2018

Conversation

methane
Copy link
Member

@methane methane commented May 26, 2015

No description provided.

@eventlistener
Copy link

@methane Hi! May I ask why this doesn't get merged?

@methane
Copy link
Member Author

methane commented Apr 13, 2017

@ycraaron
Copy link

I have found the same problem today. I think this is a bug level error and this PR should be merged.
@methane

@ycraaron
Copy link

I think this should be merged to master because it's not a new feature instead it's a bug related to max_open_connections. Here is the problem I have related to this pr. After reading the code and figuring out the problem, I find this pr, which I think is a good fix for it, hope this could be merged to master.
AmbiLabs#1

@methane
Copy link
Member Author

methane commented Mar 13, 2018

I'll merge this this time, but please don't expect I fix more bugs anymore.
I strongly recommend you to Go asyncio.

@methane methane merged commit 75d3466 into master Mar 13, 2018
@methane methane deleted the fix/opened_conns_on_connect_error branch March 13, 2018 12:49
@ycraaron
Copy link

Thanks, bro!
Our problems seem to be more complicated for the time being and Tornado-MySQL is a good choice.
Yeah, we will explore the asyncio, thanks for this merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants