Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove form-core package as it is unused and re-exported from react-form #1333

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

yjoer
Copy link
Contributor

@yjoer yjoer commented Mar 24, 2025

This PR eliminates the @tanstack/form-core package from the example, as it’s currently unused. If its functionality is needed, it's already re-exported from @tanstack/react-form. By dropping it, we avoid the hassle of keeping an extra package in sync with the adapter.

Copy link

nx-cloud bot commented Mar 24, 2025

View your CI Pipeline Execution ↗ for commit 23561b7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 57s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-24 18:07:59 UTC

Copy link

pkg-pr-new bot commented Mar 24, 2025

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crutchcorn crutchcorn merged commit 2b49fa6 into TanStack:main Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants