-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] A way to add kwarg support to #164 #165
Draft
torfjelde
wants to merge
7
commits into
subtape
Choose a base branch
from
torfjelde/kwargs-support-with-primitive
base: subtape
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de/kwargs-support-with-primitive
TBH I think I prefer this to making changes in DynamicPPL, as originally discussed. This way we keep all the complexity in Libtask, rather than shifting some of the complexity of Libtask into the design of DynamicPPL.jl |
@willtebbutt, does #179 fix the support for kwargs? |
I'm unsure whether it currently does -- it shouldn't be too hard to add though. |
It would be good to support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a branch locally with some initial work on kwarg-support, and now, thanks to #164, it works!
A few very important drawbacks:
Core.kwftype
.cache
anddeepcopy_types
that are used in Libtask.jl. This can be resolved by a) renaming those to something less common, e.g.__libtask__cache__
or something, and b) throwing an error if we hit it.EDIT: I wanted to make this PR to your branch @willtebbutt but couldn't because that branch is on your fork.