Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Overflow in Max Heap Comparator for K Closest Points to Origin #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Integer Overflow in Max Heap Comparator for K Closest Points to Origin #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions patterns/java/TopKElements.java
View file
Original file line number Diff line number Diff line change
@@ -126,7 +126,9 @@ private int getDistance(int[] point) {

public int[][] kClosestPointsToOriginMaxHeapApproach(int[][] points, int k) {
// Max heap with custom comparator to compare by distance
PriorityQueue<int[]> maxHeap = new PriorityQueue<>((a, b) -> getDistance(b) - getDistance(a));
PriorityQueue<int[]> maxHeap = new PriorityQueue<>(
(a, b) -> Integer.compare(getDistance(b), getDistance(a))
);

// Iterate through all points
for (int[] point : points) {
@@ -146,4 +148,4 @@ public int[][] kClosestPointsToOriginMaxHeapApproach(int[][] points, int k) {

return result;
}
}
}