Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneInstanceReady trigger context #14619

Closed
ChristopherBiscardi opened this issue Aug 4, 2024 · 1 comment
Closed

SceneInstanceReady trigger context #14619

ChristopherBiscardi opened this issue Aug 4, 2024 · 1 comment
Labels
A-Scenes Serialized ECS data stored on the disk C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@ChristopherBiscardi
Copy link
Contributor

The dev-docs for SceneInstanceReady state

Triggered on a scene’s parent entity when crate::SceneInstance becomes ready to use.

This is technically true, but is missing useful context like "if the scene doesn't have a parent, then the event is triggered globally" and "If you only observe the global event, you will miss events triggered for specific entities" (this second statement needs to be fact-checked, but as I was looking over the PR for thisweekinbevy it seems true).

I'll do a PR for this unless someone else gets to it first.
@ChristopherBiscardi ChristopherBiscardi added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Aug 4, 2024
@TrialDragon TrialDragon added A-Scenes Serialized ECS data stored on the disk S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Aug 5, 2024
@ChristopherBiscardi
Copy link
Contributor Author

I believe the intended effect is for the global observer to receive all events, even when triggered for a specific entity. discord source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristopherBiscardi @TrialDragon