-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create bevy_render_2d
crate
#18467
base: main
Are you sure you want to change the base?
Create bevy_render_2d
crate
#18467
Conversation
You added a new feature but didn't update the readme. Please run |
This is a split I want to see, but I'm not sure if we should do it now or wait until 0.16 is released. |
@IceSentry while I was doing this split I was wondering if The were some changes to system ordering too that needs some verification |
Yes-ish. All the wireframe material thing is currently broken and needs to be rewritten to use it's own phase. @tychedelia is working on this. Once it's done, then it could be a separate crate, but I think it should probably live in bevy_render for a bit. I don't think wireframes would cause compilation speed issues and if you want to render wireframe you'll need to use bevy_render anyway. |
Let's definitely wait until after 0.16 and try to get these done expediently as a first task so we don't get stuck in rebase hell. Haven't reviewed the concrete changes yet but thank you for tackling this. |
5e856ac
to
e80a350
Compare
bevy_render_2d
and bevy_color_material
cratesbevy_render_2d
crate
@tychedelia TLDR: Moved |
cedc832
to
c3bfb13
Compare
Objective
Work for #18423
Solution
Create
bevy_render_2d
crate and pull relevant code out ofbevy_sprite
Testing
Not enough
Migration Guide
On included file