Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly gate functionality on http in bevy_remote #18478

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Properly gate functionality on http in bevy_remote #18478

merged 1 commit into from
Mar 22, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

Noticed that bevy_remote fails to compile without default features.

Solution

Adjusted offending method to avoid reliance on http module when it is disabled.

Testing

  • CI
  • cargo clippy -p bevy_remote --no-default-features

@bushrat011899 bushrat011899 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Utils Utility functions and types P-Compile-Failure A failure to compile Bevy apps X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 22, 2025
@bushrat011899 bushrat011899 added this to the 0.16 milestone Mar 22, 2025
@mockersf mockersf added this pull request to the merge queue Mar 22, 2025
Merged via the queue into bevyengine:main with commit 4127ac1 Mar 22, 2025
39 checks passed
mockersf pushed a commit that referenced this pull request Mar 23, 2025
@bushrat011899 @mockersf
Properly gate functionality on http in bevy_remote (#18478)
39b1ffc 
# Objective

Noticed that `bevy_remote` fails to compile without default features.

## Solution

Adjusted offending method to avoid reliance on `http` module when it is
disabled.

## Testing

- CI
- `cargo clippy -p bevy_remote --no-default-features`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf

Assignees
No one assigned
Labels
A-Utils Utility functions and types C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
2 participants
@bushrat011899 @mockersf