Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local folder picker to file sync GUI #66

Closed
spikecurtis opened this issue Feb 19, 2025 · 0 comments · Fixed by #116
Closed

Add local folder picker to file sync GUI #66

spikecurtis opened this issue Feb 19, 2025 · 0 comments · Fixed by #116
Assignees

Comments

@spikecurtis
Copy link
Collaborator

Add a local folder picker to the file sync GUI. This makes it so that you can visually browse the file system right in the application, rather than having to open the native Finder.

Image

Dependencies

@ethanndickson ethanndickson linked a pull request Mar 20, 2025 that will close this issue
ethanndickson added a commit that referenced this issue Mar 28, 2025
Closes #66
Relates to #63


The UI differs a fair bit from the wireframes & figma designs in the interest of being able to use the stock SwiftUI Table view. The biggest difference is that a modal is used to insert new file syncs, as opposed to creating them inline. This was done as it's a lot harder to do that within a SwiftUI table. This design is also consistent with tables used in Apple's own settings pages, and the HTTP header table in app settings.


https://github.com/user-attachments/assets/7c3d98b9-36c4-430b-ac6f-7064b6b8dc31

The UI is mostly non-functional, it still needs to be wired up over gRPC, including conversions from Mutagen data types.
As a result, the file sync button on the menu will not appear unless the file sync feature flag is enabled in settings.

Right now, the workspace dropdown menu is populated from the online agents (any row with a coloured dot on the menubar menu)

There's no tests for this since ViewInspector still does not support Tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants