chore: add mutagen prompting gRPC #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2025
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
f0a7bbd to
fa5aeb2
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
5ca8a83 to
c11bc07
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
fa5aeb2 to
7485c0f
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
c11bc07 to
1cac28d
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
7485c0f to
2fa9ac2
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
1cac28d to
015cd0c
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
2fa9ac2 to
a1e03d6
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
015cd0c to
6a40c66
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
a1e03d6 to
8a14aa3
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
6a40c66 to
257499f
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
8a14aa3 to
397007d
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
257499f to
12fa59f
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
397007d to
4fd43fd
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
12fa59f to
af6ba71
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
4fd43fd to
916bec7
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
af6ba71 to
ae06ba2
Compare
ethanndickson
commented
Mar 24, 2025
| @@ -42,9 +42,9 @@ public class MutagenDaemon: FileSyncDaemon { | |||
| private let mutagenDaemonSocket: URL | |||
|
|
|||
| // Non-nil when the daemon is running | |||
| var client: DaemonClient? | |||
There was a problem hiding this comment.
Making this internal instead of private so we can split the daemon class up into multiple extensions, across multiple files.
| // TODO: we'll always accept prompts for now | ||
| try initResp.ensureValid(first: true, allowPrompts: allowPrompts) | ||
|
|
||
| Task.detached(priority: .background) { |
There was a problem hiding this comment.
This block is self-contained, and we're currently doing a lot on the main actor already. I was previously running into issues on startup with the VPN code getting starved by file sync code.
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
916bec7 to
1950779
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
ae06ba2 to
68dae7d
Compare
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
1950779 to
72ac481
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
68dae7d to
c7018ec
Compare
deansheather
approved these changes
Mar 25, 2025
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
72ac481 to
fb42817
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
c7018ec to
820bace
Compare
This was referenced Mar 26, 2025
ethanndickson
force-pushed
the
ethan/convert-mutagen-session
branch
from
fb42817 to
f25e09f
Compare
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
820bace to
93667f7
Compare
ethanndickson
changed the base branch from
ethan/convert-mutagen-session
to
graphite-base/118
ethanndickson
force-pushed
the
ethan/mutagen-prompting
branch
from
93667f7 to
77771a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #63.
The daemon requires this prompting communication channel be open during all requests.