feat: bypass built-in CORS handling for workspace apps #15669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
commented
Nov 27, 2024
| @@ -395,41 +397,73 @@ func (s *Server) HandleSubdomain(middlewares ...func(http.Handler) http.Handler) | |||
| return | |||
| } | |||
|
|
|||
| // Use the passed in app middlewares before checking authentication and | |||
There was a problem hiding this comment.
Note to reviewers: this is the meat of the change.
I had to move some things around here since the token was only being created after CORS was handled, and the defined behavior is stored in the token.
I moved the CORS middleware invocation into determineCORSBehavior because we needed to conditionally invoke it if behavior != passthru, only.
dannykopping
force-pushed
the
dk/cors
branch
2 times, most recently
from
c5c74d1 to
ec3bac6
Compare
dannykopping
force-pushed
the
dk/cors
branch
2 times, most recently
from
4c6beb5 to
f91f220
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
force-pushed
the
dk/cors
branch
from
79ce356 to
63c1852
Compare
dannykopping
changed the title
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
This was referenced Nov 29, 2024
|
Reopening; this has been deprioritized slightly but not forgotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is blocked; we want to first introduce this feature to port shares, as it has transpired that that use-case is far more common. It would be awkward to get this PR into the next release but not for port shares, so we're keeping this one on hold.
This PR introduces a partial fix for #15096; it allows operators to specify the CORS behavior on a per-
coder_applevel.This change requires
cors_behaviorto be set on a givencoder_app; coder/terraform-provider-coder#309 introduces that new attribute.coderdcurrently handles CORS automatically by handling preflight requests and stripping CORS headers from upstreamcoder_appresponses.Two CORS behaviors are defined in this PR:
simple: the current behavior of handling CORS withincoderdpassthru: new behavior which transparently bypasses our CORS handling incoderdso thecoder_appservice is then fully responsible for handling CORSWe plan to further add this behavior to port shares.
The sharing level (
owner,authenticated,public) is still respected, regardless of CORS behavior.