-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: hack: terraform-plugin-framework and dynamic types #354
base: main
Are you sure you want to change the base?
Conversation
johnstcn
commented
Feb 28, 2025
•
edited
Loading
edited
- using mux server to serve both old and new provider implementations
- some mucking around with dynamic types for coder parameter
I see type constraint values might still not be supported? So data "coder_parameter" "test" {
type = string // Not allowed
type = "string" // is allowed It treats See traversal to keyword: https://github.com/hashicorp/hcl/blob/main/traversal_for_expr.go#L70-L127 And on the input value: https://github.com/hashicorp/terraform/blob/main/internal/stacks/stackconfig/input_variable.go#L20-L21 (var blocks are input variables) So type constraints are just references. We might have to keep our types as quoted strings? 😢 Traversals less than 2 are considered invalid too? I am not sure where this error is raised, but it is raised somewhere by the tests. I do see where this is enforce in tflint, which I assume has some parity with terraform.
TFLint: https://github.com/terraform-linters/tflint-plugin-sdk/blob/master/terraform/addrs/parse_ref.go#L231 |
I think that's just for a resource, which is always |
Another issue with the current sdk. The current does not support pointer types? So we have to compute some helper fields? |
another reason to do this: https://github.com/coder/preview/issues/40 |