Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extra builds in package (commonjs, umd) #71

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

papandreou
Copy link
Contributor

@papandreou papandreou commented Aug 10, 2020

Context: #68 (comment)

I ended up putting the extra builds in separate directories because tsc --outFile doesn't work for --module commonjs and --module umd (apparently it doesn't bundle, so it can end up outputting multiple files).

Fixes #68

@papandreou papandreou changed the title include extra builds in package Include extra builds in package (commonjs, umd) Aug 10, 2020
@dankogai dankogai merged commit 69ce1ea into dankogai:master Aug 10, 2020
@hbarcelos
Copy link

It would be great to update the docs on how to use the new bundles.

dankogai added a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.2.x does not work with native Node.js ESM
3 participants