#3057. Add tests for the reachability of a do-while loop. #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Looks very good!
I did comment on a couple of descriptions, though, because they use a terminology which is a couple of steps away from the actual mechanism. I don't think it's very easy to avoid the issues that I mention, but I did try to make some suggestions.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 28, 2025
2025-03-28 sgrekhov22@gmail.com Fixes dart-lang/co19#3119. Fix roll failures (dart-lang/co19#3120) 2025-03-27 sgrekhov22@gmail.com dart-lang/co19#3057. Add more flow analysis tests, fix existing (dart-lang/co19#3117) 2025-03-27 sgrekhov22@gmail.com dart-lang/co19#2119. Remove obsolete "inference-using-bounds" experimental flag (dart-lang/co19#3118) 2025-03-25 sgrekhov22@gmail.com dart-lang/co19#3057. Add flow analysis tests for the `for-in` statement (dart-lang/co19#3115) 2025-03-24 sgrekhov22@gmail.com Fixes dart-lang/co19#3111. Update expected errors positions (dart-lang/co19#3113) 2025-03-24 sgrekhov22@gmail.com dart-lang/co19#3057. Add tests for the reachability of a do-while loop. (dart-lang/co19#3112) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I513c5205e80681419c2510fd817b44fd479c1c08 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418600 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.