Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [vm] If waiting for an active mutator slot for too long, steal a slot from a thread at a native safepoint. #60098

Closed
alexmarkov opened this issue Feb 11, 2025 · 1 comment
Closed

Failures on [vm] If waiting for an active mutator slot for too long, steal a slot from a thread at a native safepoint. #60098

alexmarkov opened this issue Feb 11, 2025 · 1 comment
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening triaged Issue has been triaged by sub team

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on [vm] If waiting for an active mutator slot for too long, steal a slot from a thread at a native safepoint..

The tests

vm/dart/isolates/many_isolates_blocked_at_ffi_test Timeout (expected Pass)
vm/dart/isolates/many_isolates_blocked_at_sleep_test Timeout (expected Pass)

are failing on configurations

vm-reload-linux-debug-x64
vm-reload-linux-release-x64
vm-reload-rollback-linux-debug-x64
vm-reload-rollback-linux-release-x64

@rmacnak-google Could you take a look?
@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Feb 11, 2025
@rmacnak-google
Copy link
Contributor

Hm, native and FFI calls are at a GC safepoint and a deopt safepoint but not a reload safepoint.

@a-siva a-siva added the triaged Issue has been triaged by sub team label Feb 12, 2025
@dcharkes dcharkes mentioned this issue Feb 18, 2025
Closed
copybara-service bot pushed a commit that referenced this issue Feb 19, 2025
@rmacnak-google
[vm, reload] Use the right field table when checking if the values in…
398bd83 
… shared fields still conform to the static type.

TEST=ci
Bug: #60098
Change-Id: I00d680485312027fe6bdbdf95f48a4bd3be8ec68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410743
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 13, 2025
@rmacnak-google
[vm] Allow reload during FFI and native calls.
101516e 
TEST=many_isolates_blocked_* under reload stress testing
Bug: #60098
Change-Id: Ifb9838735e1846236e30820d7d957e3a51fd9e99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410960
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmacnak-google @a-siva @alexmarkov