Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ddl): fix modify column data type null to not null failed #17650

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 25, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. fix modify column data type null to not null failed, using remove_nullable function to remove null value from the original column.
  2. nullable random column values remove unused underlaying values.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 25, 2025
@b41sh b41sh marked this pull request as draft March 25, 2025 11:14
@wubx
Copy link
Member

wubx commented Mar 25, 2025

LGTM
I've test this pr.

@b41sh b41sh requested a review from sundy-li March 25, 2025 16:19
@b41sh b41sh marked this pull request as ready for review March 25, 2025 16:19
@b41sh b41sh merged commit eae3b9e into databendlabs:main Mar 26, 2025
310 of 321 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Can't read table by alter table column from string null to string not null
3 participants