Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use actions/cache@v4 #329

Merged
merged 1 commit into from
Mar 20, 2025
Merged

ci: use actions/cache@v4 #329

merged 1 commit into from
Mar 20, 2025

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Mar 18, 2025

Fixes CI failures

image

@greg0ire
Copy link
Member

Should we do this with Dependabot instead?

@simPod
Copy link
Contributor Author

simPod commented Mar 20, 2025

Not instead of this PR since it has been already done but overall you can setup dependabot here, yes

@greg0ire
Copy link
Member

Ah indeed, it needs to be unblocked first: #330

@simPod simPod marked this pull request as ready for review March 20, 2025 14:13
@greg0ire
Copy link
Member

There are failing tests and pending checks, why is that?

@simPod
Copy link
Contributor Author

simPod commented Mar 20, 2025

there were updates in slevomat that found new errors

Pending checks are marked as required in repo but now those are run on 7.2, not 7.4

I resolved everything in #326 #327 already but review is stale there and meanwhile actions/cache@v2 stopped working...

I suggest to merge this even though checks are failing. Then continue with mentioned PRs.

@greg0ire greg0ire merged commit 74f8512 into doctrine:12.0.x Mar 20, 2025
12 of 14 checks passed
@simPod simPod deleted the action-cache branch March 20, 2025 14:45
@simPod
Copy link
Contributor Author

simPod commented Mar 20, 2025

It will need to be ported to 13.0.x too. Or let dependabot do it but also port #330 to v13. Idk on what branches it will run.

@greg0ire
Copy link
Member

The config is run on the default branch, and will target the default branch.

@simPod simPod mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants