Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加springSecurity流程补充 #142

Merged
merged 8 commits into from
Jun 8, 2023
Merged

添加springSecurity流程补充 #142

merged 8 commits into from
Jun 8, 2023

Conversation

poo0054
Copy link
Member

@poo0054 poo0054 commented Jun 5, 2023

添加springSecurity流程补充 ,未完待补充

如果有问题请及时告诉我该怎么做

@poo0054
Copy link
Member Author

poo0054 commented Jun 5, 2023

请问还需不需要补充这方面的,如果需要我会继续写完整,如果不需要的话我就关闭了

@yanglbme
Copy link
Member

yanglbme commented Jun 5, 2023

@poo0054

加个一级标题吧,然后正文从二级标题开始,参考以下:

image

@yanglbme
Copy link
Member

yanglbme commented Jun 5, 2023

请问还需不需要补充这方面的,如果需要我会继续写完整,如果不需要的话我就关闭了

可以继续完善后面的待补充内容

fix: 优化一级标签
@poo0054
Copy link
Member Author

poo0054 commented Jun 7, 2023

hi,还需要做些什么吗

@poo0054
Copy link
Member Author

poo0054 commented Jun 8, 2023

@yanglbme 现在是遇到什么问题了吗

@yanglbme
Copy link
Member

yanglbme commented Jun 8, 2023

文档写的不规范,review 起来有点困难,说以下几点:

  1. 一些专有名词,需要规范书写,比如 springSecurity 需要写成 Spring Security
  2. 中文文档,请使用中文逗号句号,而不是混用英文的逗号句号。
  3. 中文文档,有书写上的规范。我们项目使用 prettier 格式化,约定的格式见:https://github.com/doocs/source-code-hunter/blob/main/.prettierrc ,提交前需要使用 prettier 格式化。

@poo0054
Copy link
Member Author

poo0054 commented Jun 8, 2023

ok,我去改一下

@yanglbme
Copy link
Member

yanglbme commented Jun 8, 2023

代码格式相关的,也是比较混乱,我做了一些调整 017c3b3

@poo0054
Copy link
Member Author

poo0054 commented Jun 8, 2023

好的,能不能告诉我哪些方面需要更改,我好在下次提交的时候避免这些错误

@poo0054
Copy link
Member Author

poo0054 commented Jun 8, 2023

我是使用idea进行格式化的.使用的也是.prettierrc文件里面的格式化.

我非常喜欢这个项目,可以说是我的启蒙之作,我第一篇看的就是spring,然后慢慢的自己看,到现在基本上能够不用查阅资料进行源码的阅读了.我非常感谢这个项目, 不知道我还能做些什么

@yanglbme
Copy link
Member

yanglbme commented Jun 8, 2023

@poo0054 你可以参考我的改动 017c3b3

  1. 示例代码需要统一缩进格式,确保美观易读
  2. 新增文章之后,可以在根目录 README.md 中添加对应文章的引用

@yanglbme yanglbme merged commit cb336ee into doocs:main Jun 8, 2023
@yanglbme
Copy link
Member

yanglbme commented Jun 8, 2023

此次 pr 已经合并到主分支中 @poo0054 欢迎继续参与项目

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants