Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove redundant field in inherited class #1520

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

tzway
Copy link
Contributor

@tzway tzway commented Mar 9, 2025

title field is already defined in ItemBase

@tzway tzway marked this pull request as draft March 9, 2025 01:16
@tzway tzway closed this Mar 9, 2025
@tzway tzway reopened this Mar 9, 2025
@tzway tzway changed the title remove redundant field in inherited class refactor, remove redundant field in inherited class Mar 9, 2025
@tzway tzway marked this pull request as ready for review March 9, 2025 01:25
@alejsdev alejsdev changed the title refactor, remove redundant field in inherited class ♻️ Remove redundant field in inherited class Mar 19, 2025
@alejsdev alejsdev merged commit 54ca043 into fastapi:master Mar 19, 2025
20 of 22 checks passed
@alejsdev
Copy link
Member

Good catch, thanks! @tzway 🚀 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants