Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dropdown.expand has no effect #5042

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Dropdown.expand has no effect #5042

wants to merge 1 commit into from

Conversation

InesaFitsner
Copy link
Contributor

@InesaFitsner InesaFitsner commented Mar 6, 2025 •
edited by sourcery-ai bot
Loading

Description

fixes #5040

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where Dropdown controls with expand set do not have zero insets.

@ndonkoHenri ndonkoHenri changed the title fix expand issue fix: Dropdown.expand has no effect Mar 8, 2025
ndonkoHenri
ndonkoHenri reviewed Mar 25, 2025
View reviewed changes
packages/flet/lib/src/controls/dropdown.dart
Comment on lines +319 to +320
expandedInsets:
widget.control.attrInt("expand") != null ? EdgeInsets.zero : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will instead suggest that we expose this prop (expanded_insets) on the python end, and do this logic in it the before_update().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndonkoHenri ndonkoHenri

@FeodorFitsner FeodorFitsner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Dropdown ignoring expand
2 participants
@InesaFitsner @ndonkoHenri