Json result #11
Merged
Json result #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@faddiv hello and thanks for your email. I missed the notifications on this project (I have been working on things outside the .net space recently) - apologies for that. We have some merge conflicts here now. Would you mind to fix them? Thanks for the offer of help here. After a few more contributions, I'd be happy to make you a maintainer. |
# Conflicts: # src/FluentAssertions.AspNetCore.Mvc/FailureMessages.Designer.cs # src/FluentAssertions.AspNetCore.Mvc/FailureMessages.resx # src/FluentAssertions.AspNetCore.Mvc/FluentAssertions.AspNetCore.Mvc.csproj
|
Finished resolving the conflict. Everything seems fine. |
|
Thanks again for the contribution. It's in v2.2.0 which should be up on nuget in the next hour or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hy Kevin,
I added JsonResult assertions to the project. I thought it would be useful. Please review if this is fine.
This consist of the followings:
result.Should().BeJsonResult()
result.Should().BeJsonResult().WithContentType("content type");
result.Should().BeJsonResult().WithStatusCode(200);
result.Should().BeJsonResult().Value (For the JsonResult.Value)
result.Should().BeJsonResult().ValueAs() (Type checking and casting like in the ViewResult)
result.Should().BeJsonResult().SerializerSettings (For the JsonResult.SerializerSettings)
I am also interested doing further works on this project.