Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change continuous profiling API names #4265

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Mar 18, 2025

📜 Description

Renamed
Sentry.startProfileSession -> Sentry.startProfiler
Sentry.stopProfileSession -> Sentry.stopProfiler

#skip-changelog

💡 Motivation and Context

Renaming APIs to avoid confusion with sessions and sample rates

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

 Sentry.startProfileSession -> Sentry.startProfiler
 Sentry.stopProfileSession -> Sentry.stopProfiler
@stefanosiano stefanosiano marked this pull request as ready for review March 18, 2025 15:49
Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fd14d13

@stefanosiano stefanosiano requested a review from lcian as a code owner March 18, 2025 15:49
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.08 ms 488.55 ms 69.47 ms
Size 1.58 MiB 2.22 MiB 653.05 KiB

@stefanosiano stefanosiano merged commit c83e427 into main Mar 18, 2025
38 checks passed
@stefanosiano stefanosiano deleted the feat/continuous-profiling-rename-apis branch March 18, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants