Check for mixed SDK versions #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd09760 | 408.00 ms | 475.67 ms | 67.67 ms |
| f1edfce | 351.51 ms | 381.63 ms | 30.11 ms |
| 0376116 | 388.63 ms | 437.71 ms | 49.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd09760 | 1.58 MiB | 2.22 MiB | 653.31 KiB |
| f1edfce | 1.58 MiB | 2.22 MiB | 653.31 KiB |
| 0376116 | 1.58 MiB | 2.22 MiB | 653.14 KiB |
romtsn
reviewed
Mar 20, 2025
| for (SentryPackage pkg : packages) { | ||
| if (pkg.getName().startsWith("maven:io.sentry:") | ||
| && !sdkVersion.equalsIgnoreCase(pkg.getVersion())) { | ||
| logger.log( |
There was a problem hiding this comment.
I'm thinking if we should introduce a method that force-logs regardless of the debug and diagnosticLevel values set and use it here, wdyt?
romtsn
reviewed
Mar 20, 2025
romtsn
reviewed
Mar 27, 2025
| } | ||
|
|
||
| public @NotNull Set<SentryPackage> getPackages() { | ||
| return packages; | ||
| } | ||
|
|
||
| public boolean checkForMixedVersions(final @NotNull ILogger logger) { |
There was a problem hiding this comment.
I guess would be nice to have a test for this (if not yet)
romtsn
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Changelog is written in a follow up PR
📜 Description
SentryIntegrationPackageStorage.packagesfor mixed versions when sending out an envelope.This is only the first step where we log when mixed versions have been detected.
Next step is to not enable the SDK in that case.
💡 Motivation and Context
First step for solving #4132
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps