Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the shared library to provide more data for bitbucket prs (and use it here) #4141

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Extend the shared library to provide more data for bitbucket prs (and use it here) #4141

merged 2 commits into from
Mar 24, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Mar 10, 2025 •
edited
Loading

Description

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb
Copy link
Member Author

While we are waiting for the shared library to apply and publish the changes, I'm converting this PR to a draft.

@sergeibbb sergeibbb marked this pull request as draft March 10, 2025 21:33
sergeibbb added a commit that referenced this pull request Mar 10, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
5ab9319 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from 1845881 to edfc7b5 Compare March 10, 2025 21:34
sergeibbb added a commit that referenced this pull request Mar 10, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
edfc7b5 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
sergeibbb added a commit that referenced this pull request Mar 11, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
d0717da 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from edfc7b5 to 62d7e9d Compare March 11, 2025 10:18
sergeibbb added a commit that referenced this pull request Mar 11, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
62d7e9d 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb linked an issue Mar 11, 2025 that may be closed by this pull request
Extend the shared library to provide more data for Bitbucket PRs #4128
Closed
3 tasks
@sergeibbb sergeibbb mentioned this pull request Mar 11, 2025
Closed
3 tasks
sergeibbb added a commit that referenced this pull request Mar 12, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
fcf95e3 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from 62d7e9d to 4b6f9d6 Compare March 12, 2025 11:18
sergeibbb added a commit that referenced this pull request Mar 12, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
4b6f9d6 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
42e40f8 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
ed49037 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from 4b6f9d6 to ed49037 Compare March 13, 2025 11:22
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
cbe57a1 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
fee015e 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from ed49037 to fee015e Compare March 13, 2025 13:31
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
3748cea 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from fee015e to 14a8312 Compare March 24, 2025 11:58
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Uses shared library to retrieve user's Bitbucket PRs per repo.
14a8312 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb force-pushed the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch from 14a8312 to c4e8ca2 Compare March 24, 2025 12:04
@sergeibbb sergeibbb marked this pull request as ready for review March 24, 2025 12:04
@sergeibbb
Copy link
Member Author

Hi @axosoft-ramint
The version of the shared library has been published. I've updated the dependency to v0.28.2.

axosoft-ramint
axosoft-ramint approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we will want to talk through paging soon since for some providers we return everything, and for some we only return one "page" of results, however many that may be.

@sergeibbb sergeibbb merged commit ed98b94 into main Mar 24, 2025
4 checks passed
sergeibbb added a commit that referenced this pull request Mar 24, 2025
@sergeibbb
Uses shared library for fetching authored pull requests from Bitbucket
c7c6dd9 
Integrates changes from
gitkraken/provider-apis-package-js#223
Solves #4128
(#4141)
@sergeibbb sergeibbb deleted the 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs branch March 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axosoft-ramint axosoft-ramint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the shared library to provide more data for Bitbucket PRs
2 participants
@sergeibbb @axosoft-ramint