Adds create pr urls for other providers #4143

eamodio · 2025-03-12T05:41:40Z

Refs #4142

src/git/remotes/bitbucket-server.ts

src/git/remotes/bitbucket.ts

(#4142, #4143)

…k PR (#4142, #4143)

…rvices Adds configuration options for comparison and create pull request URLs to support custom remote services. Updates the relevant interfaces and abstract methods to include these new URL types. (#4142, #4143)

(#4142, #4143)

…k PR (#4142, #4143)

…rvices Adds configuration options for comparison and create pull request URLs to support custom remote services. Updates the relevant interfaces and abstract methods to include these new URL types. (#4142, #4143)

(#4142, #4143)

…k PR (#4142, #4143)

(#4142, #4143)

…k PR (#4142, #4143)

(#4142, #4143)

…k PR (#4142, #4143)

…orks (#4142, #4143)

(#4142, #4143)

…rvices Adds configuration options for comparison and create pull request URLs to support custom remote services. Updates the relevant interfaces and abstract methods to include these new URL types. (#4142, #4143)

(#4142, #4143)

…orks (#4142, #4143)

…k PR (#4142, #4143)

(#4142, #4143)

eamodio · 2025-03-27T17:32:52Z

src/git/remotes/bitbucket-server.ts

+		options?: { title?: string; description?: string },
+	): string | undefined {
+		const query = new URLSearchParams({ sourceBranch: head.branch, targetBranch: base.branch ?? '' });
+		// TODO: figure this out


Does this just need to be removed or figured out still?

@eamodio It's been waiting for bitbucket-server to be merged. But than I've switched to another task. So, yes, needs to be figured out.

axosoft-ramint · 2025-03-27T18:08:35Z

In addition to @eamodio comments above, one other issue: whenever I cancel the process at any point after seeing the "connect to " prompt for cross-repository case, I see an error toast. We should not show an error in those cases.

(#4142, #4143)

sergeibbb · 2025-03-27T19:04:16Z

@axosoft-ramint

whenever I cancel the process at any point after seeing the "connect to " prompt for cross-repository case, I see an error toast. We should not show an error in those cases.

fixed

axosoft-ramint

LGTM - once the github security/CodeQL issue is fixed, we can proceed

…rvices Adds configuration options for comparison and create pull request URLs to support custom remote services. Updates the relevant interfaces and abstract methods to include these new URL types. (#4142, #4143)

(#4142, #4143)

…orks (#4142, #4143)

…k PR (#4142, #4143)

(#4142, #4143)

eamodio mentioned this pull request Mar 12, 2025

Create Pull Request action fails for remotes other than GitHub #4142

Closed

8 tasks

github-advanced-security bot found potential problems Mar 12, 2025

View reviewed changes

src/git/remotes/bitbucket-server.ts Fixed Show resolved Hide resolved

src/git/remotes/bitbucket.ts Fixed Show fixed Hide fixed

sergeibbb added a commit that referenced this pull request Mar 13, 2025

Fixes compare and create-pr URLs for bitbucket-server

5003b13

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 13, 2025

Fixes compare URL for bitbucket cloud

a0538f3

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 17, 2025

Fixes create-repo URL for bitbucket cloud

911b8b5

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 17, 2025

Gets provider resource URL asyncronously

fd15fa5

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 17, 2025

Retrieve target repoId for AzureDevOps

e2ca401

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Lets user connect and integration when it is required for a cross-for…

38021ba

…k PR (#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Fixes compare and create-pr URLs for bitbucket-server

cede65a

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Fixes compare URL for bitbucket cloud

e7491b9

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Fixes create-repo URL for bitbucket cloud

aa105d0

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Gets provider resource URL asyncronously

5dc1f5d

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Retrieve target repoId for AzureDevOps

ac01ae2

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Lets user connect and integration when it is required for a cross-for…

4705650

…k PR (#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Gets provider resource URL asyncronously

7804bbf

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Retrieve target repoId for AzureDevOps

95f5d83

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 18, 2025

Lets user connect and integration when it is required for a cross-for…

f470126

…k PR (#4142, #4143)

sergeibbb force-pushed the feature/create-prs branch from 38021ba to f470126 Compare March 18, 2025 21:24

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Retrieve target repoId for AzureDevOps

e75a70b

(#4142, #4143)

sergeibbb force-pushed the feature/create-prs branch from f470126 to d324a33 Compare March 19, 2025 09:55

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Lets user connect and integration when it is required for a cross-for…

d324a33

…k PR (#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Fixes compare and create-pr URLs for bitbucket-server

b206ae0

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Fixes compare URL for bitbucket cloud

5fedf22

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Fixes create-repo URL for bitbucket cloud

b2a27c8

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Gets provider resource URL asyncronously

df66dfb

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Retrieve target repoId for AzureDevOps

a87cac0

(#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Lets user connect and integration when it is required for a cross-for…

0ce9e8b

…k PR (#4142, #4143)

sergeibbb added a commit that referenced this pull request Mar 19, 2025

Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…

c3cf1ff

…orks (#4142, #4143)

sergeibbb pushed a commit that referenced this pull request Mar 26, 2025

Adds create pr urls for other providers

37ca2fe

(#4142, #4143)

axosoft-ramint self-assigned this Mar 27, 2025

sergeibbb and others added 9 commits March 27, 2025 16:53

Gets provider resource URL asyncronously

7824100

(#4142, #4143)

Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…

37b442a

…orks (#4142, #4143)

Lets user connect and integration when it is required for a cross-for…

335e51e

…k PR (#4142, #4143)

Generates create GitLab PR URLs and retrieves repoId for cross-forks

9ee38b0

(#4142, #4143)

Generates create Bitbucket PR URLs

28a5220

(#4142, #4143)

Generates create Bitbucket DataCenter PR URLs (without cross-forks)

e53c6fb

(#4142, #4143)

Generates create GitHub PR URLs

bf2d1d5

(#4142, #4143)

Adds create pr urls for other providers

2ccaefa

(#4142, #4143)

sergeibbb force-pushed the feature/create-prs branch from 37ca2fe to 2ccaefa Compare March 27, 2025 15:53

eamodio commented Mar 27, 2025

View reviewed changes

Updates wording on the cross-repository prompt

a244941

Stops showing an error when user refuses to connect an integration

b2f2ab3

(#4142, #4143)

axosoft-ramint approved these changes Mar 27, 2025

View reviewed changes

Updates use of replace

27f916a

axosoft-ramint merged commit d6a2a6b into main Mar 27, 2025
3 checks passed

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Gets provider resource URL asyncronously

1b7921c

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Generates create AzureDevOps PR URLs and retrieves repoId for cross-f…

2cef8f4

…orks (#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Lets user connect and integration when it is required for a cross-for…

6b67d01

…k PR (#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Generates create GitLab PR URLs and retrieves repoId for cross-forks

c0859f5

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Generates create Bitbucket PR URLs

9326c23

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Generates create Bitbucket DataCenter PR URLs (without cross-forks)

df3a686

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Generates create GitHub PR URLs

3e6af44

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Adds create pr urls for other providers

50367c5

(#4142, #4143)

axosoft-ramint pushed a commit that referenced this pull request Mar 27, 2025

Stops showing an error when user refuses to connect an integration

d2f1dce

(#4142, #4143)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds create pr urls for other providers #4143

Adds create pr urls for other providers #4143

eamodio commented Mar 12, 2025

eamodio Mar 27, 2025

sergeibbb Mar 27, 2025

axosoft-ramint commented Mar 27, 2025

sergeibbb commented Mar 27, 2025

axosoft-ramint left a comment

Adds create pr urls for other providers #4143

Adds create pr urls for other providers #4143

Conversation

eamodio commented Mar 12, 2025

eamodio Mar 27, 2025

Choose a reason for hiding this comment

sergeibbb Mar 27, 2025

Choose a reason for hiding this comment

axosoft-ramint commented Mar 27, 2025

sergeibbb commented Mar 27, 2025

axosoft-ramint left a comment

Choose a reason for hiding this comment