[SYCL][Doc] Add test plan for sycl_ext_intel_kernel_queries extension #17593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
reviewed
Mar 25, 2025
|
|
||
| ## Tests | ||
|
|
||
| ### Unit tests |
There was a problem hiding this comment.
Sorry for delayed review. Test plan indicates that unit tests are going to be added (i.e. https://github.com/intel/llvm/tree/sycl/sycl/unittests) but corresponding PR - #17594 - actually adds e2e lit test, not a unit test.
So, please change the wording in the test plan.
There was a problem hiding this comment.
I recently discovered that that test won't be of any use. And if I add the requirement on the aspect the test would be actually dropped. I'll try to add a unittest this week that'd use mock ur.
There was a problem hiding this comment.
That sounds good, in that case this test plan looks good, but should it be moved to unittests directory?
againull
approved these changes
Mar 26, 2025
againull
pushed a commit
that referenced
this pull request
Mar 26, 2025
This adds a unittest for the kernel queries extension according to #17593.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test plan for sycl_ext_intel_kernel_queries extension.