fix NotImplementedError: get_type is not implemented #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirda7
suggested changes
Mar 2, 2025
There was a problem hiding this comment.
This is not a valid fix.
Please take a look at my comment in here:
https://jira.habana-labs.com/browse/SW-220806
you cannot have abstract methods or even class methods that throw exceptions in the base class that none of the classes that inherits from it implements.
If you want the refactor to stay - you should implement it in all classes in helper_modules.py
and only then make sure all tests with their new patched modules also implement them...
|
I think we should implement |
Signed-off-by: Xin He <xinhe3@habana.ai>
yiliu30
approved these changes
Mar 19, 2025
nirda7
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
bug fix
Description
blocking print after prepare.