python-ecosys/aiohttp: fix header - case-insensitivity #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pipeline is failing for an unrelated reason (version of GHA upload artifact) |
FuNK3Y
force-pushed
the
fix-header-case-sensitivity
branch
2 times, most recently
from
7a93168 to
e5fffb6
Compare
Signed-off-by: FuNK3Y Signed-off-by: FuNK3Y <fun__key@hotmail.com>
FuNK3Y
force-pushed
the
fix-header-case-sensitivity
branch
from
e5fffb6 to
6dddab7
Compare
FuNK3Y
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC (https://datatracker.ietf.org/doc/html/rfc7230#section-3.2) header names are case-insensitive.
This PR makes sure that the module behaves consistently regardless of the casing of
Content-typeandContent-Length(other headers are not considered by the module)Without this fix, the client seems to wait for the connection termination (~10 seconds) prior to returning any content if the casing of
Content-Lengthis different.