Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring id parameter #1622

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Stop ignoring id parameter #1622

merged 1 commit into from
Feb 11, 2025

Conversation

katcharov
Copy link
Collaborator

@katcharov katcharov requested review from a team and vbabanin and removed request for a team February 5, 2025 14:27
@rozza
Copy link
Member

rozza commented Feb 6, 2025

Recommend adding a regression test here: GridFSPublisherSpecification

@jyemin jyemin requested review from jyemin and removed request for vbabanin February 10, 2025 13:44
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without a test, but please open a ticket to investigate the seemingly total lack of testing.

@katcharov
Copy link
Collaborator Author

Opened issue here:

https://jira.mongodb.org/browse/JAVA-5787

@katcharov katcharov merged commit e4e5e69 into mongodb:main Feb 11, 2025
53 of 60 checks passed
@katcharov katcharov deleted the JAVA-5728 branch February 11, 2025 14:58
katcharov added a commit to katcharov/mongo-java-driver that referenced this pull request Feb 13, 2025
katcharov added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants