Optimize BSON codec lookup. #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `BsonTypeCodecMap` for decoding in `BsonArray` to enable faster access. - Optimize `BsonTypeClassMap` by replacing `Map` with a plain array to eliminate redundant hash computations. JAVA-5339
JAVA-5339
JAVA-5339
rozza
reviewed
Feb 25, 2025
| annotationProcessor 'org.openjdk.jmh:jmh-generator-annprocess:1.37' | ||
| } | ||
|
|
||
| tasks.register("jmh", JavaExec) { |
There was a problem hiding this comment.
Does this get run via evergreen in the same way the other benchmarks do?
There was a problem hiding this comment.
Currently, no. I initially considered adding it to Evergreen, but it would expand this PR and would require some time to test it. This task is mainly for local benchmarking to quickly assess the relative performance impact of small components. However, I think we should consider adding it to Evergreen in the future, as it could provide more insight into performance changes.
There was a problem hiding this comment.
In that case in the future it may be worth splitting jmh benchmarks into their own project.
For example reorganize both into a benchmarks folder but have separate configuration for each:
benchmarks
|
| - driver (the current driver-benchmarks)
| - jmh (jmh test suite)
Nothing to do now.
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonArrayCodecBenchmark.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonDocumentBenchmark.java
Outdated
Show resolved
Hide resolved
Using ordinal() ties the mapping to enum declaration order, which risks subtle bugs in the future. JAVA-5339
rozza
approved these changes
Feb 27, 2025
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonArrayCodecBenchmark.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonDocumentBenchmark.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonDocumentBenchmark.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonArrayCodecBenchmark.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonUtils.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonUtils.java
Outdated
Show resolved
Hide resolved
driver-benchmarks/src/main/com/mongodb/benchmark/jmh/codec/BsonUtils.java
Show resolved
Hide resolved
…nArrayCodecBenchmark.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
…nDocumentBenchmark.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
…nDocumentBenchmark.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
…nArrayCodecBenchmark.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
…nUtils.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
…nUtils.java Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
JAVA-5339
JAVA-5339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces performance optimizations for BSON encoding and decoding to improve efficiency for both BsonArrayCodec BsonDocumentCodec in codec lookups. The latest benchmarks:
BsonArrayCodec:
BsonDocumentCodec:
The BsonDocumentBenchmark parses simple BsonInt32 fields to minimize the impact of other codecs to evaluate BsonDocumentCodec's internal performance.
Changes:
BsonTypeCodecMapfor encoding and decoding inBsonArrayCodecandBsonDocumentCodecto enable faster access.BsonTypeClassMapby replacingMapwith a plain array to eliminate redundant hash computations.JAVA-5339