Adjust maxAwaitTimeMS by remaining timeout. #1650
Open
+166
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5720
JAVA-5720
JAVA-5720
vbabanin
commented
Mar 13, 2025
Comment on lines
+424
to
+509
| { | ||
| "description": "apply remaining timeoutMS if less than maxAwaitTimeMS", | ||
| "operations": [ | ||
| { | ||
| "name": "failPoint", | ||
| "object": "testRunner", | ||
| "arguments": { | ||
| "client": "failPointClient", | ||
| "failPoint": { | ||
| "configureFailPoint": "failCommand", | ||
| "mode": { | ||
| "times": 1 | ||
| }, | ||
| "data": { | ||
| "failCommands": [ | ||
| "getMore" | ||
| ], | ||
| "blockConnection": true, | ||
| "blockTimeMS": 30 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "createFindCursor", | ||
| "object": "collection", | ||
| "arguments": { | ||
| "filter": { | ||
| "_id": 1 | ||
| }, | ||
| "cursorType": "tailableAwait", | ||
| "batchSize": 1, | ||
| "maxAwaitTimeMS": 100, | ||
| "timeoutMS": 200 | ||
| }, | ||
| "saveResultAsEntity": "tailableCursor" | ||
| }, | ||
| { | ||
| "name": "iterateOnce", | ||
| "object": "tailableCursor" | ||
| }, | ||
| { | ||
| "name": "iterateUntilDocumentOrError", | ||
| "object": "tailableCursor", | ||
| "expectError": { | ||
| "isTimeoutError": true | ||
| } | ||
| } | ||
| ], | ||
| "expectEvents": [ | ||
| { | ||
| "client": "client", | ||
| "ignoreExtraEvents": true, | ||
| "events": [ | ||
| { | ||
| "commandStartedEvent": { | ||
| "commandName": "find", | ||
| "databaseName": "test" | ||
| } | ||
| }, | ||
| { | ||
| "commandStartedEvent": { | ||
| "commandName": "getMore", | ||
| "databaseName": "test", | ||
| "command": { | ||
| "maxTimeMS": { | ||
| "$$lte": 100 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "commandStartedEvent": { | ||
| "commandName": "getMore", | ||
| "databaseName": "test", | ||
| "command": { | ||
| "maxTimeMS": { | ||
| "$$lte": 70 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
The failpoint is used here to delay the first getMore by 30ms, reducing raciness and allowing verification that the second getMore occurs with maxTimeMs being less than 70ms.
3 tasks
katcharov
approved these changes
Mar 24, 2025
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
Outdated
Show resolved
Hide resolved
…fiedTestModifications.java Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
# Conflicts: # driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5720