Support placeholder values in BsonReader and BsonWriter #1652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add support for placeholder values in JSON, so that our Hibernate dialect can support native queries like
instead of the less intuitive:
It could also be used for non-native queries, but it's less important there. It would be more to make the query logs look more sensible, i.e.
instead of
The problem is that in order to fit in the BsonReader/BsonWriter framework, the change is quite invasive, including
writePlaceholder
methods toBsonWriter
readPlaceholder
methods toBsonReader
BsonPlaceholder
subclass toBsonValue
PLACEHOLDER
value to theBsonType
enumBsonPlaceholderCodec
asPlaceholder
andisPlaceholder
toBsonValue
doWritePlaceholder
method toAbstractBsonWriter
and subclasses, including one inBsonBinaryWriter
that necessarily throwsUnsupportedOperationException
since placeholder is not a real BSON typedoReadPlaceholder
method toAbstractBsonReader
and subclasses, including one inBsonBinaryReader
that necessarily throwsUnsupportedOperationException
since placeholder is not a real BSON typeIt would be hard to justify all these changes, but I thought it would be interesting for people to look at.