Bugfix FXIOS-11576 ⁃ Weird animation when the search view is shown (#25235)

FXIOS-11576 #25206 ⁃ Weird animation when the search view is shown

Author: dicarobinho

firefox-ios/Client/Frontend/Browser/Search/SearchViewController.swift

@@ -378,21 +378,21 @@ class SearchViewController: SiteTableViewController,
         _ keyboardHelper: KeyboardHelper,
         keyboardWillShowWithState state: KeyboardState
     ) {
-        animateSearchEnginesWithKeyboard(state)
+        layoutSearchEngineScrollView()
     }
 
     func keyboardHelper(
         _ keyboardHelper: KeyboardHelper,
         keyboardWillHideWithState state: KeyboardState
     ) {
-        animateSearchEnginesWithKeyboard(state)
+        layoutSearchEngineScrollView()
     }
 
     func keyboardHelper(
         _ keyboardHelper: KeyboardHelper,
         keyboardWillChangeWithState state: KeyboardState
     ) {
-        animateSearchEnginesWithKeyboard(state)
+        layoutSearchEngineScrollView()
     }
 
     override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
@@ -404,18 +404,6 @@ class SearchViewController: SiteTableViewController,
         }, completion: nil)
     }
 
-    private func animateSearchEnginesWithKeyboard(_ keyboardState: KeyboardState) {
-        layoutSearchEngineScrollView()
-
-        UIView.animate(
-            withDuration: keyboardState.animationDuration,
-            delay: 0,
-            options: [UIView.AnimationOptions(rawValue: UInt(keyboardState.animationCurve.rawValue << 16))],
-            animations: {
-                self.view.layoutIfNeeded()
-            })
-    }
-
     private func getCachedTabs() {
         // Short circuit if the user is not logged in
         guard profile.hasSyncableAccount() else { return }