Bugfix FXIOS-11544 [App Icon 2025] Remove repeated "selected" VoiceOver announcement on the selected app icon row (#25303)

ih-codes · web-flow · commit 359ad01c04e3 · 2025-03-13T09:40:50.000-06:00
Remove repeated "selected" callout on the selected app icon row.
diff --git a/firefox-ios/Client/Frontend/Settings/AppIconSelection/AppIconView.swift b/firefox-ios/Client/Frontend/Settings/AppIconSelection/AppIconView.swift
@@ -119,9 +119,9 @@ struct AppIconView: View, ThemeApplicable {
                     .foregroundStyle(themeColors.textPrimary.color)
                 Spacer()
                 if isSelected {
+                    // swiftlint:disable:next accessibility_label_for_image
                     Image(systemName: UX.checkmarkImageIdentifier)
                         .foregroundStyle(themeColors.actionPrimary.color)
-                        .accessibilityLabel(selectionImageAccessibilityLabel)
                 }
             }
             .padding(.horizontal, UX.itemPaddingHorizontal)

Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,9 @@ struct AppIconView: View, ThemeApplicable {`
`119`	`119`	`.foregroundStyle(themeColors.textPrimary.color)`
`120`	`120`	`Spacer()`
`121`	`121`	`if isSelected {`
	`122`	`+ // swiftlint:disable:next accessibility_label_for_image`
`122`	`123`	`Image(systemName: UX.checkmarkImageIdentifier)`
`123`	`124`	`.foregroundStyle(themeColors.actionPrimary.color)`
`124`		`- .accessibilityLabel(selectionImageAccessibilityLabel)`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`	`.padding(.horizontal, UX.itemPaddingHorizontal)`